Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: missing changes from build_and_push action #618

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

tiagolobocastro
Copy link
Contributor

Pull Request template

Why is this PR required? What issue does it fix?:
Missed change from previous PR

What this PR does?:
Adds changes to build_and_push yml
Also noticed a missing file in the coverage action

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/website is used to track them:

Missed changes for build_and_push yaml
todo: should have a better way of doing this other than
duplicating the code, essentially

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro tiagolobocastro changed the title Zfs mi CI: missing changes from build_and_push action Jan 28, 2025
@tiagolobocastro tiagolobocastro merged commit da8b7ad into develop Jan 28, 2025
6 checks passed
@tiagolobocastro tiagolobocastro deleted the zfs-mi branch January 28, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants