Update rbac.yaml #603
Merged
Update rbac.yaml #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
approved these changes
Dec 16, 2024
|
@Darkfella91 Thanks! Please sign your commit, before we can merge. |
Abhinandan-Purkait
requested review from
tiagolobocastro,
avishnu,
sinhaashish and
niladrih
|
Let me figure out how to do that . I'm new to this stuff. Give me a few minutes. |
tiagolobocastro
approved these changes
Dec 16, 2024
sinhaashish
approved these changes
Dec 17, 2024
|
Seems like the CI is failing. Will fix it and merge this post that. Thanks |
Signed-off-by: Darkfella91 <[email protected]>
Abhinandan-Purkait
force-pushed
the
develop
branch
from
1ee098c to
9bedad4
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #603 +/- ##
========================================
Coverage 95.99% 95.99%
========================================
Files 1 1
Lines 574 574
========================================
Hits 551 551
Misses 19 19
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?: Fixes RBAC permissions, which prevents the csi-snapshotter from patching the status of volume snapshots.
What this PR does?: Adds patch verb to the volumesnapshotcontents/status resource.
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist: