refactor(pytest): make debugging easier #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
Change a lot of return Nones for exceptions which aids debugging by failing at the point of failure Reduce verbose logging when install/upgrades takes some time due to cpu or network constraints Remove extra logging Allow using kubectl plugin from path I think the tests are currently broken for release branches as its asserting for develop. Also we're modifying the chart itself, which is not ideal. todo: improve this Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
pytest
branch
2 times, most recently
from
f82d8b0 to
be41609
Compare
When deploying a kind cluster, ensure we allocate the requested hugepages. Signed-off-by: Tiago Castro <[email protected]>
Ensure install is properly completed Ensure upgrade is properly completed Compare against v-next and not v-next since there's no current way of knowing which version is the current helm chart. This may get addressed if we start building the images and the chart as v-next from the outset. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
pytest
branch
from
be41609 to
1b1b4aa
Compare
Signed-off-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change a lot of return Nones for exceptions which aids debugging by failing at the point of failure
Reduce verbose logging when install/upgrades takes some time due to cpu or network constraints
Remove extra logging
Allow using kubectl plugin from path
I think the tests are currently broken for release branches as its asserting for develop.
Also we're modifying the chart itself, which is not ideal. todo: improve this
Description
Motivation and Context
Regression
How Has This Been Tested?
Types of changes
Checklist: