This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add historical detectors #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizheliu-amazon
approved these changes
Jan 22, 2021
ylwu-amzn
approved these changes
Jan 22, 2021
|
The historical detector does not seem to support "category" definition. |
|
hi, @agarwalvijay , thanks for your interest in historical detector. For this release in ODFE 1.13, we don't support high cardinality detector with "category" field. We are building unified flow now which will support "category" field and unify both realtime and historical detection under the same detector. You can check the RFC opendistro-for-elasticsearch/anomaly-detection#380, welcome any suggestions/comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds the historical detectors to the plugin. The
historical-workbench-devbranch includes the 5 approved PRs related to the changes. This PR is just merging all of those changes into master.Details of all of the changes & new pages can be found in the individual PRs below:
Historical detector list page: #347
Create/edit historical detector page: #349
Historical detector details/results page: #351
Other changes to make historical detectors compatible: #352
Bug fixes: #357
Have confirmed all UT and IT pass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.