Sign image and attach SBOM attestion #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrjk
reviewed
Dec 1, 2023
| } | ||
|
|
||
| func (c *CosignClient) commonArgs(imageRef string) []string { | ||
| args := []string{"--tlog-upload=false", "--key", c.key} |
There was a problem hiding this comment.
Perhaps it would be worthwhile to also allow using a custom rekor URL so one could run a private rekor instance.
If we would make the rekor url a parameter one could by default have it empty meaning it is not used. A special value could be used for not disabling using rekor and instead use it's default URL.
| @@ -88,6 +91,7 @@ var defaultOptions = options{ | |||
| buildahBuildExtraArgs: "", | |||
| buildahPushExtraArgs: "", | |||
| trivySBOMExtraArgs: "", | |||
| cosignKey: "", | |||
There was a problem hiding this comment.
Should cosignExtraArgs be added to facilitate experimentation?
|
Awesome, thanks for the feedback. I basically agree to all your mentioned points. However, they all can be added later on without breaking the current behaviour. Therefore I am going to merge this now, and when the need arises we can build on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.