Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S2 L1 tests for masking #321

Merged
merged 11 commits into from
Dec 21, 2023
Merged

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Dec 20, 2023

  • Expand the test datasets, as the packager now needs to read L1 data files for masks, not just the metadata.
  • Support for Sinergise package layouts, to fix the Sinergise tests.
  • Skip masks that are too small have data (fiona doesn't like the gml files ESA provides that are null)

@jeremyh jeremyh force-pushed the develop branch 2 times, most recently from 7ac40fc to 8e52514 Compare December 20, 2023 23:42
@jeremyh jeremyh changed the title Fix S2 L1 tests (for masking changes) Update S2 L1 tests for masking, add Sinergise support Dec 21, 2023
@jeremyh jeremyh changed the title Update S2 L1 tests for masking, add Sinergise support Update S2 L1 tests for masking Dec 21, 2023
@jeremyh jeremyh marked this pull request as ready for review December 21, 2023 01:34
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (a666bca) 84.78% compared to head (6c84222) 84.38%.
Report is 4 commits behind head on develop.

Files Patch % Lines
eodatasets3/wagl.py 67.28% 35 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #321      +/-   ##
===========================================
- Coverage    84.78%   84.38%   -0.40%     
===========================================
  Files           26       26              
  Lines         4410     4503      +93     
===========================================
+ Hits          3739     3800      +61     
- Misses         671      703      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@geoscience-aman geoscience-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested. Looks okay. Thanks @jeremyh!

@jeremyh jeremyh merged commit ea49d65 into opendatacube:develop Dec 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants