-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update S2 L1 tests for masking #321
Conversation
jeremyh
commented
Dec 20, 2023
•
edited
Loading
edited
- Expand the test datasets, as the packager now needs to read L1 data files for masks, not just the metadata.
- Support for Sinergise package layouts, to fix the Sinergise tests.
- Skip masks that are too small have data (fiona doesn't like the gml files ESA provides that are null)
7ac40fc
to
8e52514
Compare
We now no longer skip different resolutions on S2.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #321 +/- ##
===========================================
- Coverage 84.78% 84.38% -0.40%
===========================================
Files 26 26
Lines 4410 4503 +93
===========================================
+ Hits 3739 3800 +61
- Misses 671 703 +32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not tested. Looks okay. Thanks @jeremyh!