Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telemetry-atomic description #1238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

romeyod
Copy link
Contributor

@romeyod romeyod commented Jan 2, 2025

  • (M) aft/openconfig-aft-common.yang

Change Scope

  • Update telemetry-atomic description to clarify the list container behavior.
  • This change is backwards compatible.

@romeyod romeyod requested a review from a team as a code owner January 2, 2025 17:47
Comment on lines 173 to 179
protocol message. When the annotation is specified in the context
of a list of containers, it applies to individual list elements
(subtree or container and all elements under that subtree) of the
list and not to the entire list. For example, say ipv4-entry list
has two elements, prefix1 and prefix2, all elements under the
prefix1 subtree may be updated as a result of a next-hop group
change while prefix2 subtree is not updated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more clear to say something like:
"the atomic property applies to the contents of each individual keyed entry in the list."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dplore for the feedback. I have updated the description accordingly.

@dplore
Copy link
Member

dplore commented Jan 3, 2025

/gcbrun

@OpenConfigBot
Copy link

No major YANG version changes in commit 6446f85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants