Localize use of PatternMatchEngine #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of domino-effect here; the full refactor required getting rid of the int index into the clauses.
linas
added a commit
to linas/opencog
that referenced
this pull request
Dec 26, 2019
See opencog/atomspace#2453 for the matching update
|
Merging; this needs opencog/opencog#3625 to pass all unit tests. |
|
Ugh. opencog actually requires #2455 to pass... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to historical design reasons, the PatternMatchEngine had invasively invaded
too many corners of the code. As a result, efforts to parallelize the pattern matcher,
such as #2316 got complicated and off-track. This pull req is part one of a series to
isolate it down to one small area, which will make parallelization much easier to
accomplish.