changed member links to link values #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeUserName1
force-pushed
the
AttentionSCM
branch
from
cf2ac7c to
8551b3a
Compare
|
This looks reasonable to me; however, @misgeatgit should review it for accuracy & correctness. Maybe @amebel since I think they use this stuff in ghost. Also -- please do not move the class declaration to a .h file. This is a private class, it does not define an API, it should not be visible in a .h file. It needs to stay permanently hidden, in the .c file. |
|
Hello @misgeatgit @amebel |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exchanged the MemberLinks for a PredicateNode, LinkValue pair for performance reasons according to comment on #1750
Unit test run, function tested by hand in the guile shell