Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use URL rewrite instead of redirect in Nignx #11

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: use URL rewrite instead of redirect in Nignx #11

merged 1 commit into from
Dec 1, 2023

Conversation

chrisgacsal
Copy link
Contributor

Description

Fix permanent redirect which was returning 404 for URLs /clamav/* by using internal URL rewrite in nginx configuration making it transparent from the client side.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner December 1, 2023 07:47
@chrisgacsal chrisgacsal self-assigned this Dec 1, 2023
@chrisgacsal chrisgacsal added the bug Something isn't working label Dec 1, 2023
@chrisgacsal chrisgacsal merged commit 2ed8821 into main Dec 1, 2023
2 checks passed
@chrisgacsal chrisgacsal deleted the fix-nginx-redirect branch December 1, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgecse lgecse lgecse approved these changes

Assignees

@chrisgacsal chrisgacsal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgacsal @lgecse