-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take care of libraries #364
base: main
Are you sure you want to change the base?
Conversation
platformio.ini
Outdated
https://github.com/amandel/esp32_https_server.git#hotfix/openbikesensor | ||
; TODO: https://github.com/jasenk2/esp32_https_server.git#esp_tls | ||
; https://github.com/amandel/esp32_https_server.git#hotfix/openbikesensor | ||
https://github.com/jasenk2/esp32_https_server.git#esp_tls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fork does not include the CN fix - when I remember correctly this was mainly needed for Apple devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @schiermi for the contribution!
OK, I missed the CN fix. I should be able to test certificates, generated based on this branch, with Apple devices in the next days. |
Great! Would be good to find the one well maintained fork of the lib! |
Verified successfully & opened PR. |
4a70594
to
fcd9fae
Compare
fcd9fae
to
4007be2
Compare
A build containing those changes was tested for three weeks "on the bike". Testing included track uploads & OBS Webinterface access.