fix: allowPartialPeriodInterestCalculation

[rhopman]

Description

Due to a typo, the allowPartialPeriodInterestCalculation field was not processed correctly.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

[adamsaghy]

@rhopman Kindly rebase this PR.

[adamsaghy]

This fix requires changes at the backend side as well, as this field has the typo there as well!

[rhopman]

@adamsaghy good catch. I thought I checked for that but apparently I made a mistake. Let me look into this. The backend change would be breaking, so that would not be an easy fix.

[adamsaghy]

@adamsaghy good catch. I thought I checked for that but apparently I made a mistake. Let me look into this. The backend change would be breaking, so that would not be an easy fix.

Yes, probably it would be recommended to announce in the Fineract DEV mail list this change!

[rhopman]

I did a bit more research. Although the typo is indeed also present in the Fineract backend, it doesn't appear everywhere in the API. I checked the following relevant API endpoints:

• GET /v1/loanproducts: no typo
• POST /v1/loanproducts: typo
• PUT /v1/loanproducts/{productId}: typo
• GET /v1/loanproducts/{productId}: no typo
• POST /v1/loans: typo
• PUT /v1/loans/{loanId}: typo
• GET /v1/loans/{loanId}: no typo

I think the cleanest solution is to fix the typo throughout the frontend, and then make small adjustments (with comments) whenever the typo needs to be re-introduced before sending it to the backend.

@adamsaghy please review again.