Add an OTLP receiver to Weaver to prepare for the weaver registry live-check command
#548
+6,104
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
lquerel
changed the title
weaver registry live-check command
jerbly
reviewed
Jan 16, 2025
…the server is ready or an error occurs
…e that occurs on Windows in the CI/CD pipeline.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
=====================================
Coverage 74.6% 74.6%
=====================================
Files 51 51
Lines 3965 3965
=====================================
+ Hits 2958 2959 +1
+ Misses 1007 1006 -1 ☔ View full report in Codecov by Sentry. |
…ten_otlp_requests function.
jerbly
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to facilitate the creation of commands such as validating the compliance of an OTLP stream against a semconv registry or generating a semconv registry from an OTLP stream.
Weaver is already used in the context of a CI/CD pipeline, this is simply about extending the possibilities for validation or semconv registry generation in a more live context.
An
otlp-receivercan now easily be launched within Weaver to implement these commands or any other commands that make sense in this context. A skeleton of the commandweaver registry live-checkis provided to help future contribution.Notes:
build.rsexplaining to regenerate the vendored gRPC stubs. Most of the files presents in this PR are either proto files or code generated from those proto files.Next Step:
Someone will implement the
weaver registry live-checkcommand. A great example of this approach was demonstrated by @jerbly during the Semantic Convention Tooling SIG on January 15, 2025.