RabbitMQ: Specify how to populate messaging.destination.name

[joaopgrassi]

Fixes #1529

Changes

Specify in more detail how to populate messaging.destination.name for RabbitMQ. I based it on the Default exchange docs. My understanding is that a routing key is always present, even when using the default exchange (empty in this case). The routing key then is the queue name.

For all other cases, I left it as amq.default which is what RabbitMQ uses. I saw reference for it for example here: https://www.rabbitmq.com/docs/access-control

For convenience RabbitMQ maps AMQP 0-9-1's default exchange's blank name to 'amq.default' when performing permission checks.

Merge requirement checklist

• CONTRIBUTING.md guidelines followed.
• Change log entry added, according to the guidelines in When to add a changelog entry.
  • If your PR does not need a change log, start the PR title with [chore]
• schema-next.yaml updated with changes to existing conventions.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[lmolkova]

LGTM with some small suggestions

[joaopgrassi]

@trask I moved the text to the yaml file instead in f48427f. I think it makes more sense.

@lmolkova what do you think?

[lmolkova]

Thank you!

[carlosalberto]

Overall LGTM but I see that in the consumer side, you don't ever use amq.default ever - is it because it's not even possible to use the default exchange without a routing key?

[joaopgrassi]

Overall LGTM but I see that in the consumer side, you don't ever use amq.default ever - is it because it's not even possible to use the default exchange without a routing key?

Yes, AFAIK for consumers there's always a queue, which also can be the same as the routing key in the 'default exchange' case. https://www.rabbitmq.com/tutorials/amqp-concepts#consumers