Fix invalid links to Prometheus and Go API pages #6235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chalin
commented
Feb 6, 2025
chalin
commented
- Contributes to [chore] Ensure that external link fragments are valid #6196
opentelemetrybot
requested review from
a team and
djaglowski
and removed request for
a team
chalin
commented
Feb 6, 2025
Comment on lines
36
to
+37
| [Prometheus]: | ||
| https://prometheus.io/docs/prometheus/latest/feature_flags/#otlp-receiver | ||
| https://prometheus.io/docs/prometheus/2.55/feature_flags/#otlp-receiver |
There was a problem hiding this comment.
This fixes the link, but the fact that an OTLP-receiver entry no longer exists in the latest version of the docs is probably an indication that this prose needs to be updated (and/or the link to point to something else in the latest docs)?
There was a problem hiding this comment.
@open-telemetry/collector-approvers ☝️
chalin
commented
Feb 6, 2025
| [enable Prometheus' OTLP Receiver](https://prometheus.io/docs/prometheus/latest/feature_flags/#otlp-receiver) | ||
| [enable Prometheus' OTLP Receiver](https://prometheus.io/docs/prometheus/2.55/feature_flags/#otlp-receiver) |
There was a problem hiding this comment.
There was a problem hiding this comment.
@open-telemetry/collector-approvers ☝️
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
3942587 to
f966a51
Compare
chalin
changed the title
svrnm
approved these changes
Feb 6, 2025
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
7ce1cec to
619c6dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.