Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add java17 as compatible runtime in collector makefile #1667

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: add java17 as compatible runtime in collector makefile #1667

merged 2 commits into from
Jan 23, 2025

Conversation

arun-annamalai
Copy link
Contributor

@arun-annamalai arun-annamalai commented Jan 15, 2025 •
edited by tylerbenson
Loading

Closes #1666

@arun-annamalai arun-annamalai requested a review from a team as a code owner January 15, 2025 21:40
serkan-ozal
serkan-ozal reviewed Jan 16, 2025
View reviewed changes
collector/Makefile Outdated Show resolved Hide resolved
tylerbenson
tylerbenson approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to @serkan-ozal's request, I suggest adding a comment to each language's layer publish workflow that points here, encouraging any updates to be applied in both places.

@serkan-ozal
Copy link
Contributor

@arun-annamalai can you revert changes in the go.mod files as they are irrelevant to this PR

@arun-annamalai
Copy link
Contributor Author

Reverted Go mod changes and put out another revision. Thank you for noticing.

@arun-annamalai
Copy link
Contributor Author

Could someone with merge permissions merge this in for me?

@serkan-ozal
Copy link
Contributor

@tylerbenson are we good to merge this?

@tylerbenson tylerbenson added the java Pull requests that update Java code label Jan 23, 2025
@tylerbenson tylerbenson added the go Pull requests that update Go code label Jan 23, 2025
@tylerbenson tylerbenson merged commit 7f3b53e into open-telemetry:main Jan 23, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

@serkan-ozal serkan-ozal serkan-ozal approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetry Lambda Collector makefile should include support for Java17 runtime
3 participants
@arun-annamalai @serkan-ozal @tylerbenson