Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-native-app] cleanup build instructions #1860

Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Dec 23, 2024

Changes

This updates the Readme for the react-native-app. All commands to run have not changed.

  1. Adds structure to the file with use of H3 and H4 blocks
  2. Re-orders some steps that only need to be run the first time
  3. Re-orders troubleshooting to have topics show up in same order as build instructions
  4. Enforces line breaks at 80 characters on each line
  5. Removes link to Android Developer site that causes maxRedirects error with markdown-link-check

@puckpuck puckpuck requested a review from a team as a code owner December 23, 2024 01:51
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianocosta89 julianocosta89 merged commit 19cbfea into open-telemetry:main Dec 23, 2024
31 checks passed
@puckpuck puckpuck deleted the react-native.cleanup-readme branch December 24, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants