Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: mount host filesystem as bind rslave mount (#1728)" #1755

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

rogercoll
Copy link
Contributor

@rogercoll rogercoll commented Oct 28, 2024

This reverts commit a1cfe47.

Annotations are not needed with latest Docker compose released version: https://github.com/docker/compose/releases/tag/v2.29.7

 $ docker compose version
Docker Compose version 2.29.7
$ make start 2&> /dev/null && echo $?
docker compose --env-file .env --env-file .env.override up --force-recreate --remove-orphans --detach

OpenTelemetry Demo is running.
Go to http://localhost:8080 for the demo UI.
Go to http://localhost:8080/jaeger/ui for the Jaeger UI.
Go to http://localhost:8080/grafana/ for the Grafana UI.
Go to http://localhost:8080/loadgen/ for the Load Generator UI.
Go to http://localhost:8080/feature/ to to change feature flags.
0

Changes

Please provide a brief description of the changes here.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@rogercoll rogercoll requested a review from a team as a code owner October 28, 2024 18:04
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Oct 28, 2024
@julianocosta89 julianocosta89 merged commit 167729a into open-telemetry:main Oct 28, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants