Fix default batcher to correctly call all done callbacks exactly once #12260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
mx-psi,
dmathieu,
a team and
dmitryax
as code owners
bogdandrutu
force-pushed
the
fix-default-batcher
branch
3 times, most recently
from
4d5f936 to
fcf0d41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12260 +/- ##
=======================================
Coverage 91.26% 91.27%
=======================================
Files 466 466
Lines 25566 25586 +20
=======================================
+ Hits 23334 23354 +20
Misses 1816 1816
Partials 416 416 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
fix-default-batcher
branch
3 times, most recently
from
659002a to
d7e2f60
Compare
dmitryax
reviewed
Feb 4, 2025
dmitryax
reviewed
Feb 4, 2025
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
fix-default-batcher
branch
from
d7e2f60 to
4f5c2a5
Compare
dmitryax
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12247