[service] ensure endpoint is prefixed w/ scheme #12258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can enter the OTLP endpoint w/o a scheme in the prefix. This causes issues with the URL parsing code in the config package. Fixes open-telemetry#12254 Signed-off-by: Alex Boten <[email protected]>
|
Note this code could be removed in the future if we decided to make parsing of the endpoint more strict, but for now it allows users not to make changes to their config |
Signed-off-by: Alex Boten <[email protected]>
TylerHelmuth
reviewed
Feb 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12258 +/- ##
=======================================
Coverage 91.30% 91.31%
=======================================
Files 465 466 +1
Lines 25658 25686 +28
=======================================
+ Hits 23426 23454 +28
Misses 1816 1816
Partials 416 416 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <[email protected]>
TylerHelmuth
approved these changes
Feb 3, 2025
bogdandrutu
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users can enter the OTLP endpoint w/o a scheme in the prefix. This causes issues with the URL parsing code in the config package.
Fixes #12254