-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pprofile aggregation temporality constants #12253
base: main
Are you sure you want to change the base?
Add pprofile aggregation temporality constants #12253
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12253 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 466 467 +1
Lines 25586 25595 +9
=======================================
+ Hits 23354 23363 +9
Misses 1816 1816
Partials 416 416 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deviates from the protobuf, right? Is the intent to add it to the protobuf later?
Hmm how does this deviate from the protobuf? It's adding public definitions for protobuf enums that are otherwise private. |
780bc47
to
582e27c
Compare
Ah, I was not aware this is part of protobuf. Maybe "deviate" is not the right word; what I meant is that this was not generated code as it is the case in the metrics constants and I didn't understand why. Seems like it's all good now :) |
This adds constants to more easily use the aggregation temporality enum in pprofile.
This behavior is very similar to how pmetrics handles those constants.
See https://pkg.go.dev/go.opentelemetry.io/collector/pdata/pmetric#pkg-constants
cc @rockdaboot