Skip to content

Commit

Permalink
[chore] Revert the change in processortest setting creation (#12107)
Browse files Browse the repository at this point in the history
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Revert the `nop_processor.NewNopSettings` change, as it is no longer
needed.
<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #11433


<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation
  • Loading branch information
zzzk1 authored Jan 17, 2025
1 parent c14d4f9 commit a3c7d95
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 4 deletions.
25 changes: 25 additions & 0 deletions .chloggen/revert-change-name.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: processorteset

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Revert the nop_processor.NewNopSettings change, as it is no longer needed

# One or more tracking issues or pull requests related to the change
issues: [11433]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
2 changes: 1 addition & 1 deletion processor/processortest/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module go.opentelemetry.io/collector/processor/processortest
go 1.22.0

require (
github.com/google/uuid v1.6.0
github.com/stretchr/testify v1.10.0
go.opentelemetry.io/collector/component v0.117.0
go.opentelemetry.io/collector/component/componentstatus v0.117.0
Expand All @@ -25,6 +24,7 @@ require (
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
Expand Down
4 changes: 1 addition & 3 deletions processor/processortest/nop_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ package processortest // import "go.opentelemetry.io/collector/processor/process
import (
"context"

"github.com/google/uuid"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/consumer"
Expand All @@ -22,7 +20,7 @@ var nopType = component.MustNewType("nop")
// NewNopSettings returns a new nop settings for Create* functions.
func NewNopSettings() processor.Settings {
return processor.Settings{
ID: component.NewIDWithName(nopType, uuid.NewString()),
ID: component.NewID(nopType),
TelemetrySettings: componenttest.NewNopTelemetrySettings(),
BuildInfo: component.NewDefaultBuildInfo(),
}
Expand Down

0 comments on commit a3c7d95

Please sign in to comment.