Refactor network detectors to kotlin #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Jan 16, 2025
| @@ -116,6 +116,9 @@ public Builder carrier(@Nullable Carrier carrier) { | |||
| } | |||
|
|
|||
| public Builder subType(@Nullable String subType) { | |||
| if ((subType != null) && subType.isEmpty()) { | |||
There was a problem hiding this comment.
Suggested change
| if ((subType != null) && subType.isEmpty()) { | |
| if ((subType.isNullOrEmpty()) { |
There was a problem hiding this comment.
That will NPE right?
There was a problem hiding this comment.
There was a problem hiding this comment.
That is indeed super nice! And does this also monkey patch the java classes? Because this is still java.....
There was a problem hiding this comment.
I won't work from Java, though maybe we can take the opportunity to switch it to Kotlin? It doesn't seem like it'll be a complicated class to change.
There was a problem hiding this comment.
I think you could subType?.isNullOrEmpty() ?: true or similar with Java interop.
marandaneto
approved these changes
Jan 16, 2025
LikeTheSalad
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #736, this refactors the two network detectors to be in kotlin, and simplifies a few things.