Rum initialization async #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the ANR issues occurring due to synchronous IO operations on the main thread during the initialization of the OpenTelemetry SDK. The fix implements a buffered, thread-safe mechanism that temporarily stores signals in memory until a delegate exporter is asynchronously set up. Once the delegate is ready, the buffered signals are flushed to it, and subsequent exports are directed to the delegate.
I went back and forth on how to do a few things in here. One of the goals with this PR is to be consistent with existing sdk code. So while the approach im taking here may not be beautiful, I think it should fit with the existing code