Feat/calc SInc based on last d #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I've understood correctly, this looks like a rather minor improvement - is it ok to skip this for the 23.10 release and include it in the next patch update instead? I'm nervous about pulling in changes this close to a release. (not suggesting you delay merging here; just asking whether you wanted this merged into Anki immediately) |
|
Feel free to delay it. I haven't modified the add-on and run the benchmark. Only one thing should be noticed: the model's structure is changed, so the user should re-optimize the parameters when the next patch releases. |
asukaminato0721
approved these changes
Oct 27, 2023
asukaminato0721
approved these changes
Oct 27, 2023
L-M-Sherlock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.