Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding translation rules to README #116

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 6, 2023

Description

In this PR, I added a translation guidelines section to the README file. This will encourage non-English or bilingual people an opportunity to contribute to the project, and fulfill one of our goals: to make this project more culturally-inclusive.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #93
Relates to #71

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

Note to Reviewers

I was heavily inspired byAstro's Docs approach to encouraging translation contributions. Now I placed this in draft mode because I'm debating on whether to create the translating guide and add it to this PR or do it in another PR after this one is merged. Any feedback is helpful.

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Rick from "Rick & Morty" looks confused

@CBID2 CBID2 requested a review from BekahHW October 6, 2023 21:44
@CBID2 CBID2 self-assigned this Oct 6, 2023
Copy link
Member

@BekahHW BekahHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBID2 CBID2 marked this pull request as ready for review October 19, 2023 15:10
@BekahHW
Copy link
Member

BekahHW commented Oct 19, 2023

@CBID2 as soon as you update your branch and change if from a draft PR, I think this is ready to be merged.

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 19, 2023

@CBID2 as soon as you update your branch and change if from a draft PR, I think this is ready to be merged.

Done @BekahHW

@CBID2 CBID2 merged commit 32a0743 into open-sauced:main Oct 19, 2023
@CBID2 CBID2 deleted the adding-information-about-translation-to-read-me-file branch October 19, 2023 15:12
@ivansftdejc
Copy link

I am new to open source, how can I help with contribution?

@CBID2
Copy link
Contributor Author

CBID2 commented Nov 1, 2023

I am new to open source, how can I help with contribution?

Hi @ivansftdejc. You've come to the right place! 😊 We have an intro course to help you get started: https://intro.opensauced.pizza/#/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add translation rules and guide to README
3 participants