fix: now search input is no longer squised on non-macOS devices #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used ternary operator to switch width, didnot use w-72 as the header logo gets very small when approaching sm breakpoint fix open-sauced#3481
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nickytonline
approved these changes
May 28, 2024
nickytonline
approved these changes
May 28, 2024
nickytonline
changed the title
|
@nickytonline if it's okay to ask, what is the tool you used to show the design across different platforms? |
brandonroberts
approved these changes
May 28, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
May 28, 2024
## [2.32.0](v2.31.0...v2.32.0) (2024-05-28) ### 🐛 Bug Fixes * added more padding between footer and highlights ([#3483](#3483)) ([352cde5](352cde5)) * now if a dynamic widget errors out, StarSearch continues to work ([#3474](#3474)) ([f840d6b](f840d6b)) * now search input is no longer squised on non-macOS devices ([#3487](#3487)) ([15d70ce](15d70ce)) * now StarSearch suggestion boxes have uniform widths ([#3471](#3471)) ([1302d33](1302d33)) * now the outline button shows button text when disabled ([#3485](#3485)) ([cb8bd3a](cb8bd3a)) * **search:** only show one not found message ([#3477](#3477)) ([7714523](7714523)) * update feed highlight to StarSearch ([#3489](#3489)) ([c99921a](c99921a)) ### 🍕 Features * Adds URL parameter validators to fetch requests ([#3467](#3467)) ([4c056d9](4c056d9)) * Updates error copy StarSearch ([#3494](#3494)) ([735c8c6](735c8c6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Used ternary operator to switch between w-56 and w-64, did not use w-72 as the header logo gets very small when approaching sm breakpoint.
Related Tickets & Documents
Fixes #3481
Mobile & Desktop Screenshots/Recordings
Before
Non-macOS
macOS
After
Non-macOS
macOS
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?