chore: add helper tooltip to dashboard highlight cards #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OgDev-01
changed the title
OgDev-01
requested review from
brandonroberts,
nickytonline,
isabensusan and
BekahHW
|
Made a tiny update to the y-axis padding of the tooltip |
|
@OgDev-01 is there a way to make the tooltip appear in the same place in every card? If you look at your screenshots, the one on spam is outside of the card. |
jpmcb
reviewed
Dec 12, 2023
Thank you for bringing this up. The tooltip placement you've noticed is intentional and aligns with the default behavior of tooltips in the Radix. The tooltips are designed to appear relative to their parent elements, which in this case is the card title. The |
bdougie
added
requested changes
and removed
needs review
OgDev-01
added
needs review
brandonroberts
approved these changes
Dec 19, 2023
brandonroberts
added
needs-second-review
and removed
needs review
open-sauced bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
## [1.80.0-beta.6](v1.80.0-beta.5...v1.80.0-beta.6) (2023-12-19) ### 🐛 Bug Fixes * fix pagination logic ([#2361](#2361)) ([4eff912](4eff912)) ### 🍕 Features * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([b6a4662](b6a4662)) * use GitHub API to search for contributors to add to a list ([#2344](#2344)) ([e5ea086](e5ea086))
open-sauced bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
## [1.80.0](v1.79.2...v1.80.0) (2023-12-19) ### ✅ Tests * <SingleSelect /> Storybook story ([3d2008b](3d2008b)) * <SingleSelect /> Storybook story ([#2340](#2340)) ([1eae960](1eae960)) ### 🐛 Bug Fixes * added focus styles for radio buttons and comboboxes ([dfc88ba](dfc88ba)) * added focus styles for radio buttons and comboboxes ([#2319](#2319)) ([0c168c7](0c168c7)) * fix pagination logic ([#2361](#2361)) ([4eff912](4eff912)) * fixed colour contrast issues on user settings page ([578892b](578892b)) * fixed colour contrast issues on user settings page ([#2351](#2351)) ([a27a9ea](a27a9ea)) * fixed colour contrast issues with contributor profile ([f656c6d](f656c6d)) * fixed colour contrast issues with contributor profile ([#2345](#2345)) ([661e91f](661e91f)) * fixed colour contrast issues with language switch selected state ([d3fe8df](d3fe8df)) * fixed colour contrast issues with language switch selected state ([#2370](#2370)) ([aa5e7ad](aa5e7ad)) * fixed colour contrast issues with tool tabs ([4eaceb5](4eaceb5)) * fixed colour contrast issues with tool tabs ([#2357](#2357)) ([e322352](e322352)) * fixed colour contrast issues with top navigation ([#2347](#2347)) ([e9d37b2](e9d37b2)) * increase z-index of show latest pull request button ([d0b7722](d0b7722)) * Issue [#2332](#2332) Removed the message "Sorry couldn't find contributors" while the contributor list is loading. ([#2339](#2339)) ([a892701](a892701)) * issue [#2332](#2332) Removed the message while the contributor list is loading ([6ff8c20](6ff8c20)) * language interests are accessible now ([f244aab](f244aab)) * language interests are accessible now via keyboard ([#2365](#2365)) ([be84d90](be84d90)) * now destructive variant is used for destructive actions in the app ([aea90a5](aea90a5)) * now destructive variant is used for destructive actions in the app ([#2356](#2356)) ([2478e33](2478e33)) * now the add more button for adding more contributors to a list is the primary CTA ([09df01c](09df01c)) * now the add more button for adding more contributors to a list is the primary CTA ([#2334](#2334)) ([ef070f2](ef070f2)) * pull request button shows PRs now on a contributor card ([#2277](#2277)) ([a87bdff](a87bdff)) * quick fix for build error introduced in [#2371](#2371) ([#2378](#2378)) ([135568f](135568f)) * removed empty className props ([#2349](#2349)) ([0f48c69](0f48c69)) * set base style text colour ([ddcda5c](ddcda5c)) ### 🍕 Features * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([b6a4662](b6a4662)) * created a destructive button variant ([#2354](#2354)) ([b1d491f](b1d491f)) * make single select component searchable ([#2061](#2061)) ([69e605e](69e605e)) * use GitHub API for user search box ([#2331](#2331)) ([152b933](152b933)) * use GitHub API to search for contributors to add to a list ([#2344](#2344)) ([e5ea086](e5ea086))
nickytonline
pushed a commit
that referenced
this pull request
Dec 20, 2023
nickytonline
pushed a commit
that referenced
this pull request
Dec 20, 2023
## [1.80.0-beta.6](v1.80.0-beta.5...v1.80.0-beta.6) (2023-12-19) ### 🐛 Bug Fixes * fix pagination logic ([#2361](#2361)) ([4eff912](4eff912)) ### 🍕 Features * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([b6a4662](b6a4662)) * use GitHub API to search for contributors to add to a list ([#2344](#2344)) ([e5ea086](e5ea086))
nickytonline
pushed a commit
that referenced
this pull request
Dec 20, 2023
## [1.80.0](v1.79.2...v1.80.0) (2023-12-19) ### ✅ Tests * <SingleSelect /> Storybook story ([3d2008b](3d2008b)) * <SingleSelect /> Storybook story ([#2340](#2340)) ([1eae960](1eae960)) ### 🐛 Bug Fixes * added focus styles for radio buttons and comboboxes ([dfc88ba](dfc88ba)) * added focus styles for radio buttons and comboboxes ([#2319](#2319)) ([0c168c7](0c168c7)) * fix pagination logic ([#2361](#2361)) ([4eff912](4eff912)) * fixed colour contrast issues on user settings page ([578892b](578892b)) * fixed colour contrast issues on user settings page ([#2351](#2351)) ([a27a9ea](a27a9ea)) * fixed colour contrast issues with contributor profile ([f656c6d](f656c6d)) * fixed colour contrast issues with contributor profile ([#2345](#2345)) ([661e91f](661e91f)) * fixed colour contrast issues with language switch selected state ([d3fe8df](d3fe8df)) * fixed colour contrast issues with language switch selected state ([#2370](#2370)) ([aa5e7ad](aa5e7ad)) * fixed colour contrast issues with tool tabs ([4eaceb5](4eaceb5)) * fixed colour contrast issues with tool tabs ([#2357](#2357)) ([e322352](e322352)) * fixed colour contrast issues with top navigation ([#2347](#2347)) ([e9d37b2](e9d37b2)) * increase z-index of show latest pull request button ([d0b7722](d0b7722)) * Issue [#2332](#2332) Removed the message "Sorry couldn't find contributors" while the contributor list is loading. ([#2339](#2339)) ([a892701](a892701)) * issue [#2332](#2332) Removed the message while the contributor list is loading ([6ff8c20](6ff8c20)) * language interests are accessible now ([f244aab](f244aab)) * language interests are accessible now via keyboard ([#2365](#2365)) ([be84d90](be84d90)) * now destructive variant is used for destructive actions in the app ([aea90a5](aea90a5)) * now destructive variant is used for destructive actions in the app ([#2356](#2356)) ([2478e33](2478e33)) * now the add more button for adding more contributors to a list is the primary CTA ([09df01c](09df01c)) * now the add more button for adding more contributors to a list is the primary CTA ([#2334](#2334)) ([ef070f2](ef070f2)) * pull request button shows PRs now on a contributor card ([#2277](#2277)) ([a87bdff](a87bdff)) * quick fix for build error introduced in [#2371](#2371) ([#2378](#2378)) ([135568f](135568f)) * removed empty className props ([#2349](#2349)) ([0f48c69](0f48c69)) * set base style text colour ([ddcda5c](ddcda5c)) ### 🍕 Features * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([b6a4662](b6a4662)) * created a destructive button variant ([#2354](#2354)) ([b1d491f](b1d491f)) * make single select component searchable ([#2061](#2061)) ([69e605e](69e605e)) * use GitHub API for user search box ([#2331](#2331)) ([152b933](152b933)) * use GitHub API to search for contributors to add to a list ([#2344](#2344)) ([e5ea086](e5ea086))
open-sauced bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
## [1.81.0-beta.1](v1.80.0...v1.81.0-beta.1) (2023-12-20) ### 🍕 Features * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([9429233](9429233)) ### 🐛 Bug Fixes * added a constant for our fallback empty data value ([7ea28e1](7ea28e1)) * added a constant for our fallback empty data value ([#2374](#2374)) ([48cf2c4](48cf2c4)) * fix pagination logic ([#2361](#2361)) ([073fb85](073fb85)) * now interests are not fallbacks for most used languages ([6fc1273](6fc1273)) * now interests are not fallbacks for most used languages ([e2ff7fd](e2ff7fd)) * now interests are not fallbacks for most used languages ([#2373](#2373)) ([7e68217](7e68217)) * now you can navigate back to the previous page from a user profile page ([9a4c538](9a4c538)) * now you can navigate back to the previous page from a user profile page ([#2382](#2382)) ([7d15dca](7d15dca))
open-sauced bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
## [1.81.0-alpha.1](v1.80.0...v1.81.0-alpha.1) (2024-01-03) ### 🐛 Bug Fixes * added a constant for our fallback empty data value ([7ea28e1](7ea28e1)) * added a constant for our fallback empty data value ([#2374](#2374)) ([48cf2c4](48cf2c4)) * added contributions treemap loading view ([e47e3b6](e47e3b6)) * added contributions treemap loading view ([#2383](#2383)) ([c6c94b3](c6c94b3)) * fix pagination logic ([#2361](#2361)) ([073fb85](073fb85)) * Hotfix to bust app-cache ([#2387](#2387)) ([d1f35ed](d1f35ed)) * now interests are not fallbacks for most used languages ([6fc1273](6fc1273)) * now interests are not fallbacks for most used languages ([e2ff7fd](e2ff7fd)) * now interests are not fallbacks for most used languages ([#2373](#2373)) ([7e68217](7e68217)) * now you can navigate back to the previous page from a user profile page ([9a4c538](9a4c538)) * now you can navigate back to the previous page from a user profile page ([#2382](#2382)) ([7d15dca](7d15dca)) ### 🍕 Features * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([9429233](9429233)) * Introduce v2 API and user PR Timescale integration ([#2293](#2293)) ([e80d2f2](e80d2f2)) * Make insight pages more agnostic and use new v1/insight API functionality ([#2368](#2368)) ([5813beb](5813beb))
open-sauced bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
## [1.81.0](v1.80.0...v1.81.0) (2024-01-04) ### 📝 Documentation * add sidebar component prototype to storybook ([#2377](#2377)) ([9e15943](9e15943)) ### 🐛 Bug Fixes * activity list contributions treemap nodes are keyboard navigable now ([60ac568](60ac568)) * activity list contributions treemap nodes are keyboard navigable now ([#2388](#2388)) ([bd2141c](bd2141c)) * added a constant for our fallback empty data value ([7ea28e1](7ea28e1)) * added a constant for our fallback empty data value ([#2374](#2374)) ([48cf2c4](48cf2c4)) * added contributions treemap loading view ([e47e3b6](e47e3b6)) * added contributions treemap loading view ([#2383](#2383)) ([c6c94b3](c6c94b3)) * Added state for reactions dropdown on highlight cards. ([#2409](#2409)) ([5f334f8](5f334f8)) * fix pagination logic ([#2361](#2361)) ([073fb85](073fb85)) * Hotfix to bust app-cache ([#2387](#2387)) ([d1f35ed](d1f35ed)) * now interests are not fallbacks for most used languages ([6fc1273](6fc1273)) * now interests are not fallbacks for most used languages ([e2ff7fd](e2ff7fd)) * now interests are not fallbacks for most used languages ([#2373](#2373)) ([7e68217](7e68217)) * now page limit dropdown filters works on repo table ([#2227](#2227)) ([fdcc081](fdcc081)) * now you can navigate back to the previous page from a user profile page ([9a4c538](9a4c538)) * now you can navigate back to the previous page from a user profile page ([#2382](#2382)) ([7d15dca](7d15dca)) * removed treemap prototype ([17cb4d8](17cb4d8)) * removed treemap prototype ([#2392](#2392)) ([04c7f29](04c7f29)) * Revert "fix: fixed releases breaking from SWC by turning it off ([#2394](#2394))" ([#2397](#2397)) ([0d2775d](0d2775d)) ### 🍕 Features * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([9429233](9429233)) * contributions treemap filtered by owners now ([#2391](#2391)) ([3944293](3944293)) * insights page are available to non logged in users ([#2226](#2226)) ([23e19fa](23e19fa)) * Make insight pages more agnostic and use new v1/insight API functionality ([#2368](#2368)) ([5813beb](5813beb)) * now contributions treemap can resize ([#2401](#2401)) ([d524fb0](d524fb0)) * replace contribution distribution chart with contributors table in list overview page ([#2385](#2385)) ([a9db0dd](a9db0dd))
Closed
2 tasks
jpmcb
added a commit
that referenced
this pull request
Jan 12, 2024
* added a constant for our fallback empty data value ([7ea28e1](7ea28e1)) * added a constant for our fallback empty data value ([#2374](#2374)) ([48cf2c4](48cf2c4)) * added contributions treemap loading view ([e47e3b6](e47e3b6)) * added contributions treemap loading view ([#2383](#2383)) ([c6c94b3](c6c94b3)) * fix pagination logic ([#2361](#2361)) ([073fb85](073fb85)) * Hotfix to bust app-cache ([#2387](#2387)) ([d1f35ed](d1f35ed)) * now interests are not fallbacks for most used languages ([6fc1273](6fc1273)) * now interests are not fallbacks for most used languages ([e2ff7fd](e2ff7fd)) * now interests are not fallbacks for most used languages ([#2373](#2373)) ([7e68217](7e68217)) * now you can navigate back to the previous page from a user profile page ([9a4c538](9a4c538)) * now you can navigate back to the previous page from a user profile page ([#2382](#2382)) ([7d15dca](7d15dca)) * add helper tooltip to dashboard highlight cards ([#2309](#2309)) ([9429233](9429233)) * Introduce v2 API and user PR Timescale integration ([#2293](#2293)) ([e80d2f2](e80d2f2)) * Make insight pages more agnostic and use new v1/insight API functionality ([#2368](#2368)) ([5813beb](5813beb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds helper tooltip to dashboard highlights cards
What type of PR is this? (check all applicable)
Related Tickets & Documents
closes #1806
Mobile & Desktop Screenshots/Recordings
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?