Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miscellaneous feed styling fixes #2220

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Nov 28, 2023

Description

Small tweaks to the feed based on feedback from Isa.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #2221

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2023-11-28 at 14 05 41

CleanShot 2023-11-28 at 14 06 04

After

CleanShot 2023-11-28 at 14 05 03

CleanShot 2023-11-28 at 14 06 34

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Nov 28, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 68728b9
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6567203ea62db200086937e7
😎 Deploy Preview https://deploy-preview-2220--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 68728b9
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6567203ec60b3b0008a4caa9
😎 Deploy Preview https://deploy-preview-2220--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@NsdHSO NsdHSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickytonline nickytonline merged commit 8399017 into beta Nov 29, 2023
11 checks passed
@nickytonline nickytonline deleted the nickytonline/feed-styling-fixes branch November 29, 2023 13:24
open-sauced bot pushed a commit that referenced this pull request Nov 29, 2023
## [1.78.0-beta.6](v1.78.0-beta.5...v1.78.0-beta.6) (2023-11-29)

### πŸ› Bug Fixes

* miscellaneous feed styling fixes ([28bfe26](28bfe26))
* miscellaneous feed styling fixes ([#2220](#2220)) ([8399017](8399017))
open-sauced bot pushed a commit that referenced this pull request Nov 29, 2023
## [1.78.0](v1.77.1...v1.78.0) (2023-11-29)

### πŸ§‘β€πŸ’» Code Refactoring

* fix tailwind anti-pattern ([5dcb958](5dcb958))
* fix tailwind anti-pattern in feed footer ([#2088](#2088)) ([1f10046](1f10046))

### πŸ• Features

* updating contributor language column  ([#2183](#2183)) ([660b861](660b861))

### πŸ› Bug Fixes

* added global styles for checkbox focus state ([#2206](#2206)) ([6999a95](6999a95))
* cleaned up list activity graph title styling ([#2224](#2224)) ([a38d9bd](a38d9bd))
* fix broken URL when you are using Range filter ([#2204](#2204)) ([fcf8080](fcf8080))
* fixed based font size so it's on body now ([c0b00ca](c0b00ca))
* fixed based font size so it's on body now ([#2219](#2219)) ([8000aed](8000aed))
* improved type inference of interests and recommendations ([2ee0c68](2ee0c68))
* improved type inference of interests and recommendations ([#2192](#2192)) ([ec29a79](ec29a79))
* list activity and contirbutor page rerender issue ([#2214](#2214)) ([86eae2c](86eae2c))
* made checkbox stroke thicker ([df53b8d](df53b8d))
* made checkbox stroke thicker ([#2212](#2212)) ([1d7781a](1d7781a))
* miscellaneous feed styling fixes ([28bfe26](28bfe26))
* miscellaneous feed styling fixes ([#2220](#2220)) ([8399017](8399017))
* now list activity graphs only load data client-side ([#2215](#2215)) ([5d1c906](5d1c906))
* Remove Netlify CLI from dev dependencies ([#2207](#2207)) ([54562c5](54562c5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styling: miscellaneous tweaks to feed
4 participants