Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match skeleton high with container card #2150

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Nov 15, 2023

Description

This PR fixes the skeleton loader height on the dashboard highlight card

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

fixes #2147

Mobile & Desktop Screenshots/Recordings

Before

image

After

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Nov 15, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 83070c8
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/655c4b07cea4a500088d053e
😎 Deploy Preview https://deploy-preview-2150--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 83070c8
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/655c4b07b8f196000875dd7c
😎 Deploy Preview https://deploy-preview-2150--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OgDev-01 OgDev-01 added the needs review PRs that need review from core engineering team label Nov 21, 2023
@OgDev-01 OgDev-01 marked this pull request as ready for review November 21, 2023 06:15
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒

@brandonroberts brandonroberts merged commit 4786117 into beta Nov 21, 2023
11 checks passed
@brandonroberts brandonroberts deleted the ogdev/2147-fix-skeleton-loader-height branch November 21, 2023 14:23
open-sauced bot pushed a commit that referenced this pull request Nov 21, 2023
### [1.77.1-beta.1](v1.77.0...v1.77.1-beta.1) (2023-11-21)

### πŸ› Bug Fixes

* match skeleton high with container card ([#2150](#2150)) ([4786117](4786117))
* reset base font size in * selector in global.css ([#2184](#2184)) ([6ae3751](6ae3751))
open-sauced bot pushed a commit that referenced this pull request Nov 21, 2023
### [1.77.1](v1.77.0...v1.77.1) (2023-11-21)

### πŸ› Bug Fixes

* added missing svelte svg ([#2196](#2196)) ([d27794c](d27794c))
* match skeleton high with container card ([#2150](#2150)) ([4786117](4786117))
* reset base font size in * selector in global.css ([#2184](#2184)) ([6ae3751](6ae3751))

### πŸ§‘β€πŸ’» Code Refactoring

* move limit query from state to urlParams ([#2153](#2153)) ([0d2825d](0d2825d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: skeleteon components too large in highlight cards
3 participants