feat: add account deletion flow #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
changed the title
nickytonline
force-pushed
the
nickytonline/danger-zone
branch
6 times, most recently
from
b6264ec to
5c7f6ba
Compare
nickytonline
force-pushed
the
nickytonline/danger-zone
branch
3 times, most recently
from
3bdb815 to
c7fdf04
Compare
nickytonline
force-pushed
the
nickytonline/danger-zone
branch
from
c7fdf04 to
708ca2a
Compare
|
@nickytonline are we able to add a "Type CONFIRM" to confirm, similar to deleting insight pages? Also can you share what is blocking this here? |
We can type CONFIRM. I'll go grab that from the insights code.
I have a PR up for that https://github.com/open-sauced/api/pull/395 |
nickytonline
force-pushed
the
nickytonline/danger-zone
branch
3 times, most recently
from
04bc8fc to
cf2b031
Compare
nickytonline
force-pushed
the
nickytonline/danger-zone
branch
from
cf2b031 to
f81c72b
Compare
nickytonline
commented
Oct 27, 2023
nickytonline
commented
Oct 31, 2023
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
## [1.74.0-beta.4](v1.74.0-beta.3...v1.74.0-beta.4) (2023-10-31) ### 🍕 Features * add account deletion flow ([#1990](#1990)) ([daeb10e](daeb10e))
|
Want to comment earlier before this was merged but the UI for the danger zone, same as insights with the a grey background
|
open-sauced bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
## [1.74.0](v1.73.0...v1.74.0) (2023-11-06) ### 🍕 Features * add account deletion flow ([#1990](#1990)) ([daeb10e](daeb10e)) * add contributor's when editing a list ([#2016](#2016)) ([1a0b4da](1a0b4da)) * add GitHub Org Repositories sync to insight page creation ([#2023](#2023)) ([e5f38ac](e5f38ac)) * add GitHub team import to new list page ([#2006](#2006)) ([3113a74](3113a74)) * add grey background for delete account ([#2030](#2030)) ([ea10161](ea10161)) ### 🐛 Bug Fixes * add check to allow team member access for private insight pages ([#2049](#2049)) ([2e48b95](2e48b95)) * change avatar alignment with highlight input ([#2032](#2032)) ([dc409c4](dc409c4)) * change label style of bio to bold ([#2033](#2033)) ([647fca3](647fca3)) * chart tooltip cut in contributors card ([#2029](#2029)) ([7c16863](7c16863)) * code standard errors ([e93bdca](e93bdca)) * don't recommend discordapp & use user's full id ([c5cad45](c5cad45)) * don't recommend discordapp as url & use user's full id ([#2014](#2014)) ([58df997](58df997)) * dropdown flickery on single highlight card ([#2040](#2040)) ([672ce2f](672ce2f)) * eslint issue by using `eslint-disable` ([#1993](#1993)) ([bc285a2](bc285a2)) * made notifications buttons more accessible ([#2034](#2034)) ([50bcf9d](50bcf9d)) * occurence eslint disable ([3d84665](3d84665)) * remove build commands from netlify.toml ([#2018](#2018)) ([138a125](138a125)) * ToggleSwitch component has required label via aria-label or aria-labelledby ([#2035](#2035)) ([0684081](0684081))
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the account deletion flow to the app. The only way you can test this is by deleting your own account in beta. Once tested, your soft delete can be reset, but it's a manual process.
To test this, head to https://deploy-preview-1990--oss-insights.netlify.app/user/settings and scroll to the bottom to delete your account.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes https://github.com/open-sauced/engineering/issues/174
Relates to https://github.com/open-sauced/api/pull/396
fixes #1990
Mobile & Desktop Screenshots/Recordings
Desktop
Smaller Screens
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?