Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dark mode #1147

Closed
wants to merge 3 commits into from

Conversation

takanome-dev
Copy link
Contributor

@takanome-dev takanome-dev commented May 7, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds dark mode to the platform

Related Tickets & Documents

Fixes #56

Mobile & Desktop Screenshots/Recordings

Just the beginning...

dash-1

dash-2

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented May 7, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 398e65b
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/645c1726941f3600088786b5
😎 Deploy Preview https://deploy-preview-1147--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 7, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 398e65b
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/645c1726df2df10008707f12
😎 Deploy Preview https://deploy-preview-1147--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdougie
Copy link
Member

bdougie commented May 11, 2023

Thanks for opening this @takanome-dev.

We haven't had bandwidth to explore dark mode in this app, but there was some work to make this approachable.

https://github.com/open-sauced/insights/blob/beta/tailwind.config.js#L121

update:

Looks like you are using that, but it doesn't cover all edge cases. We will need to document what is not covered to start cleaning this up.

@takanome-dev
Copy link
Contributor Author

Looks like you are using that, but it doesn't cover all edge cases. We will need to document what is not covered to start cleaning this up.

Sure πŸ‘

@adiati98
Copy link
Member

Hi,
Is this issue still open for contribution? If so, may I try to work on this?
Thanks! 😊

@jpmcb
Copy link
Member

jpmcb commented Aug 28, 2023

Hi @adiati98 - let's move the conversation to #56 where there looks to be some talk of implementation details and you can assign yourself πŸ‘πŸΌ

@takanome-dev takanome-dev deleted the 56-add-dark-mode branch August 28, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Front-End] Implement Dark Mode
4 participants