Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: After adding the repository, the "Add to page" button remains visible in the suggested bar. #2247

Closed
2 tasks done
Himanshuch8055 opened this issue Dec 2, 2023 · 14 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@Himanshuch8055
Copy link
Contributor

Describe the bug

When a user creates a new Insight on the Insight page, a suggested repo bar is displayed. When the user adds the repo to their page using the "add to page" button, the repo is properly added to their page. However, the problem arises when the repo is added to the page, as the "add to page" button still remains visible. It should either be removed or replaced with a check mark or some other indication to help the user understand that the repo has already been added to their page.

Create.Insight.Page._.Open.Sauced.Insights.and.6.more.pages.-.Personal.-.Microsoft_.Edge.2023-12-02.19-00-11.mp4

Steps to reproduce

  1. Goto to the "Insights page"
  2. Click on "New Insight"
  3. Scroll down.......
  4. Click on the "Add to page" button.

Browsers

Edge

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@Himanshuch8055 Himanshuch8055 added 🐛 bug Something isn't working 👀 needs triage labels Dec 2, 2023
Copy link
Contributor

github-actions bot commented Dec 2, 2023

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@MrCyberlord
Copy link

.take

@Himanshuch8055
Copy link
Contributor Author

@MrCyberlord "What's the update?"

@MrCyberlord
Copy link

I am on it. Will solve the issue soon.

@Himanshuch8055
Copy link
Contributor Author

Ok 👍

sourabpramanik added a commit to sourabpramanik/open-sauced-app that referenced this issue Dec 27, 2023
In the suggested repositories list the added respository can be removed from the cart and the button
label changes from "Add to page" to "Remove" which highlights that the repository is already added
to the page/cart

"fixes issue #open-sauced#2247"
@sourabpramanik
Copy link
Contributor

sourabpramanik commented Dec 27, 2023

@MrCyberlord I will be drafting a PR which will fix this issue. If you want to or have already fixed this issue and willing to raise a PR then please let me know I will remove mine.

@MrCyberlord
Copy link

@sourabpramanik No issues. Please carry on.

@sourabpramanik
Copy link
Contributor

sourabpramanik commented Dec 27, 2023

@MrCyberlord can you please assign me this issue then?

Or you can unassign yourself and I will take it from there.

@Himanshuch8055
Copy link
Contributor Author

Himanshuch8055 commented Dec 28, 2023

"Hello, could you kindly unassign this issue from @MrCyberlord and assign it to @sourabpramanik, @nickytonline and @BekahHW ? Thank you."

@takanome-dev
Copy link
Contributor

@Himanshuch8055, I think this is already resolved. Can you confirm it, please?

@Himanshuch8055
Copy link
Contributor Author

@takanome-dev It is still there!

@sourabpramanik
Copy link
Contributor

Yes it is there guys!

@Himanshuch8055
Copy link
Contributor Author

@sourabpramanik "What about your PR? You created a PR, why is it still there?"

@sourabpramanik
Copy link
Contributor

Well it's still not merged and under review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants