-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: After adding the repository, the "Add to page" button remains visible in the suggested bar. #2247
Comments
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself. For full info on how to contribute, please check out our contributors guide. |
.take |
@MrCyberlord "What's the update?" |
I am on it. Will solve the issue soon. |
Ok 👍 |
In the suggested repositories list the added respository can be removed from the cart and the button label changes from "Add to page" to "Remove" which highlights that the repository is already added to the page/cart "fixes issue #open-sauced#2247"
@MrCyberlord I will be drafting a PR which will fix this issue. If you want to or have already fixed this issue and willing to raise a PR then please let me know I will remove mine. |
@sourabpramanik No issues. Please carry on. |
@MrCyberlord can you please assign me this issue then? Or you can unassign yourself and I will take it from there. |
"Hello, could you kindly unassign this issue from @MrCyberlord and assign it to @sourabpramanik, @nickytonline and @BekahHW ? Thank you." |
@Himanshuch8055, I think this is already resolved. Can you confirm it, please? |
@takanome-dev It is still there! |
Yes it is there guys! |
@sourabpramanik "What about your PR? You created a PR, why is it still there?" |
Well it's still not merged and under review |
Describe the bug
When a user creates a new Insight on the Insight page, a suggested repo bar is displayed. When the user adds the repo to their page using the "add to page" button, the repo is properly added to their page. However, the problem arises when the repo is added to the page, as the "add to page" button still remains visible. It should either be removed or replaced with a check mark or some other indication to help the user understand that the repo has already been added to their page.
Create.Insight.Page._.Open.Sauced.Insights.and.6.more.pages.-.Personal.-.Microsoft_.Edge.2023-12-02.19-00-11.mp4
Steps to reproduce
Browsers
Edge
Additional context (Is this in dev or production?)
No response
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: