Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Adding already added repos show show "already added" message. #2500

Closed
2 tasks done
aryanas159 opened this issue Jan 19, 2024 · 5 comments
Closed
2 tasks done

Bug: Adding already added repos show show "already added" message. #2500

aryanas159 opened this issue Jan 19, 2024 · 5 comments
Labels
🐛 bug Something isn't working 👀 needs triage

Comments

@aryanas159
Copy link
Contributor

Describe the bug

On the Insight edit page when adding repos that are already added there should be an error or a toast message saying "Repo already added". When handling a large number of repositories the users may be confused if the repository is added or not, since clicking the Add repository button currently does nothing if the repo is already added.

Untitled.video.-.Made.with.Clipchamp.3.mp4

Steps to reproduce

  1. Go to the insights edit page.
  2. Add a repo that is already added to the page.

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@aryanas159 aryanas159 added 🐛 bug Something isn't working 👀 needs triage labels Jan 19, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@sourabpramanik
Copy link
Contributor

Hey, @aryanas159 there is a similar issue #2247 already raised before and I have also raised a PR #2407 for this. I am attaching a GIF to showcase the changes. Let me know if you like it.
fix

@aryanas159
Copy link
Contributor Author

aryanas159 commented Jan 19, 2024

@sourabpramanik Oh cool. The fix looks good, let's see what the maintainers think about this. However, if my recent pull request #2499 is merged, it may require a few changes.

@sourabpramanik
Copy link
Contributor

@aryanas159 sure thing I guess merging won't be the problem, we can make the necessary changes to reflect both

@BekahHW
Copy link
Member

BekahHW commented Jan 28, 2024

It looks like this issue has been resolved, so I'm going to close it. If there are still questions or you don't think it was adequately addressed, feel free to reopen the issue.

@BekahHW BekahHW closed this as completed Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👀 needs triage
Projects
None yet
Development

No branches or pull requests

3 participants