Editing #387
Draft
Editing #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of two console error messages: - "Warning: Circle2: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead." - "Warning: CircleSwatch2: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead." See: casesandberg/react-color#888
|
|
I updated the vite config and license report config to get the samples to build. Nitpick: the react-color dependency looks unmaintained and references some very old packages (e.g. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing capabilities are, of course, a central part of many GIS apps. However, the current implementation is limited to polygons and the OGC Features API.
This pull request suggests a more general-purpose editing solution, which evolved throughout one of our projects. Features include:
To test this implementation, open the following local sample: http://localhost:5173/samples/editing-sample/. For ease of testing, this sample saves the created features to the browser's IndexedDB.
This solution is not expected to be feature-complete or to meet everyone's needs. For one thing, it is still lacking documentation.
(screenshots: 1, 2)