feat: Add flagd provider #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecolella
force-pushed
the
jc-add-openfeature-flag-provider
branch
from
b41fbb0 to
d432126
Compare
josecolella
commented
Dec 27, 2022
josecolella
commented
Dec 27, 2022
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/client.rb
Outdated
Show resolved
Hide resolved
josecolella
commented
Dec 27, 2022
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/configuration.rb
Outdated
Show resolved
Hide resolved
beeme1mr
reviewed
Dec 27, 2022
Signed-off-by: Jose Colella <[email protected]>
Signed-off-by: Jose Colella <[email protected]>
Signed-off-by: Jose Colella <[email protected]>
Signed-off-by: Jose Colella <[email protected]>
josecolella
force-pushed
the
jc-add-openfeature-flag-provider
branch
from
d432126 to
027d004
Compare
josecolella
commented
Dec 30, 2022
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/client.rb
Show resolved
Hide resolved
Signed-off-by: Jose Colella <[email protected]>
josecolella
force-pushed
the
jc-add-openfeature-flag-provider
branch
from
027d004 to
4a0804b
Compare
beeme1mr
reviewed
Jan 3, 2023
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/client.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Jose Colella <[email protected]>
Signed-off-by: Jose Colella <[email protected]>
Signed-off-by: Jose Colella <[email protected]>
|
@beeme1mr Just addressed your comments. Let me know if there's anything else. If you could re-review so I can start working on the release of the provider |
beeme1mr
previously approved these changes
Jan 4, 2023
toddbaert
reviewed
Jan 4, 2023
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/client.rb
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Jan 4, 2023
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/configuration.rb
Show resolved
Hide resolved
toddbaert
reviewed
Jan 4, 2023
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/client.rb
Show resolved
Hide resolved
toddbaert
reviewed
Jan 4, 2023
toddbaert
reviewed
Jan 4, 2023
toddbaert
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Thanks so much @josecolella ! This is great and will be very helpful for users interested in using flagd, as well as for doing integration testing on the SDK.
My only real concern is this
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Jose Miguel Colella <[email protected]>
Signed-off-by: Jose Colella <[email protected]>
…vider/client.rb Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Jose Miguel Colella <[email protected]>
Thank you @toddbaert for helping me getting this up and running. I created issues to address the follow up on socket and secure connect as well as additional information on submodules and building the schemas |
beeme1mr
approved these changes
Jan 4, 2023
toddbaert
approved these changes
Jan 5, 2023
beeme1mr
pushed a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](openfeature-flagd-provider-v0.0.1...openfeature-flagd-provider/v0.1.0) (2024-05-16) ### ⚠ BREAKING CHANGES * update flagd name and grpc schema ([#30](#30)) ### ✨ New Features * Add flagd provider ([#2](#2)) ([98b695b](98b695b)) * Add support for unix socket path and secure connection ([#8](#8)) ([88436c7](88436c7)) * Flagd provider uses structs from sdk ([#24](#24)) ([d437e7f](d437e7f)) * integrate flagd provider with OpenFeature SDK ([#18](#18)) ([80d6d02](80d6d02)) * Return default value on error ([#25](#25)) ([f365c6d](f365c6d)) * update flagd name and grpc schema ([#30](#30)) ([ddd438a](ddd438a)) ### 🧹 Chore * Format with standard ([#20](#20)) ([bf25043](bf25043)) * Make things work ([#13](#13)) ([5968037](5968037)) * update link to use new doc domain ([#12](#12)) ([9baff65](9baff65)) * upgrade grpc client ([#16](#16)) ([23ed78a](23ed78a)) ### 🔄 Refactoring * OpenFeature::FlagD::Provider::Configuration ([#14](#14)) ([3686eb5](3686eb5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
References #1
Notes
Follow-up Tasks
How to test