Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make things work #13

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

alxckn
Copy link
Contributor

@alxckn alxckn commented Apr 6, 2024

This PR

  • Tests pass
  • Upgrade ruby to 3.1.4

Follow-up Tasks

  • Regenerate grpc client
  • Setup CI (github action?)
  • Integration testing (e.g. flagd provider in separate docker container)
  • Refactoring:
    • Configuration #merge is doing the opposite of what ruby's Hash#merge does (e.g. { a: :b }.merge(a: :c) gives {:a=>:b} instead of {:a=>:c}

How to test

Run rspec

Tests pass
Upgrade ruby to 3.1.4

Signed-off-by: Alexandre Chakroun <[email protected]>
@alxckn alxckn changed the title Make things work chore: Make things work Apr 6, 2024
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! The Ruby sdk is under active development, so it's great to have an updated provider we can use. We'll just need to set up publishing soon.

@beeme1mr beeme1mr merged commit 5968037 into open-feature:main Apr 6, 2024
3 checks passed
beeme1mr pushed a commit that referenced this pull request May 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](openfeature-flagd-provider-v0.0.1...openfeature-flagd-provider/v0.1.0)
(2024-05-16)


### ⚠ BREAKING CHANGES

* update flagd name and grpc schema
([#30](#30))

### ✨ New Features

* Add flagd provider
([#2](#2))
([98b695b](98b695b))
* Add support for unix socket path and secure connection
([#8](#8))
([88436c7](88436c7))
* Flagd provider uses structs from sdk
([#24](#24))
([d437e7f](d437e7f))
* integrate flagd provider with OpenFeature SDK
([#18](#18))
([80d6d02](80d6d02))
* Return default value on error
([#25](#25))
([f365c6d](f365c6d))
* update flagd name and grpc schema
([#30](#30))
([ddd438a](ddd438a))


### 🧹 Chore

* Format with standard
([#20](#20))
([bf25043](bf25043))
* Make things work
([#13](#13))
([5968037](5968037))
* update link to use new doc domain
([#12](#12))
([9baff65](9baff65))
* upgrade grpc client
([#16](#16))
([23ed78a](23ed78a))


### 🔄 Refactoring

* OpenFeature::FlagD::Provider::Configuration
([#14](#14))
([3686eb5](3686eb5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants