Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: coverage improvements and chores #65

Merged
merged 8 commits into from
Jan 2, 2023
Merged

Conversation

tcarrio
Copy link
Member

@tcarrio tcarrio commented Jan 2, 2023

This PR

  • test: add shared base hook classes cases
  • fix!: rename finallyAfter to finally in AbstractHook
  • refactor: default to set NoOpProvider
  • chore: cleanup commented code for $_SESSION
  • test: can get version from Client
  • feat: hook execution reversal
  • test: cases for NoOpClient
  • test: implement decapitalize unit tests

Related Issues

Fixes #54
Fixes #64
Fixes #55
Fixes #63
Fixes #57
Fixes #62
Fixes #59
Fixes #60

Notes

Follow-up Tasks

How to test

So many unit tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Merging #65 (b192128) into main (446648a) will increase coverage by 4.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #65      +/-   ##
============================================
+ Coverage     91.18%   95.19%   +4.01%     
+ Complexity      228      227       -1     
============================================
  Files            40       40              
  Lines           590      583       -7     
============================================
+ Hits            538      555      +17     
+ Misses           52       28      -24     
Impacted Files Coverage Δ
src/OpenFeatureAPI.php 93.33% <100.00%> (+2.70%) ⬆️
src/OpenFeatureClient.php 99.13% <100.00%> (+1.61%) ⬆️
src/implementation/flags/NoOpClient.php 100.00% <0.00%> (+13.33%) ⬆️
src/implementation/common/StringHelper.php 100.00% <0.00%> (+50.00%) ⬆️
src/implementation/hooks/FloatHook.php 100.00% <0.00%> (+100.00%) ⬆️
src/implementation/hooks/ObjectHook.php 100.00% <0.00%> (+100.00%) ⬆️
src/implementation/hooks/StringHook.php 100.00% <0.00%> (+100.00%) ⬆️
src/implementation/hooks/BooleanHook.php 100.00% <0.00%> (+100.00%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tcarrio tcarrio changed the title Test/coverage improvements 2 test: coverage improvements and chores Jan 2, 2023
@tcarrio tcarrio merged commit 5dc93aa into main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants