feat(flagd): add flag metadata #1151
Draft
+80
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
force-pushed
the
1115-flagd-update-in-process-resolver-to-support-flag-metadata
branch
from
76ae337 to
e6653d9
Compare
beeme1mr
commented
Jan 7, 2025
| @@ -107,6 +107,8 @@ For general information on events, see the [official documentation](https://open | |||
|
|
|||
| ### Flag Metadata | |||
|
|
|||
| TODO: Add message about flag metadata and how it's merged | |||
There was a problem hiding this comment.
Extend this description to describe the new functionality.
beeme1mr
commented
Jan 7, 2025
| "scripts": { | ||
| "publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi", | ||
| "current-version": "echo $npm_package_version" | ||
| }, | ||
| "peerDependencies": { | ||
| "@grpc/grpc-js": "~1.8.0 || ~1.9.0 || ~1.10.0 || ~1.11.0 || ~1.12.0", | ||
| "@openfeature/server-sdk": "^1.13.0" | ||
| "@openfeature/server-sdk": "^1.17.0" |
There was a problem hiding this comment.
Check with @toddbaert to see if flagd-core needs to be set here.
beeme1mr
commented
Jan 7, 2025
| @@ -15,22 +14,13 @@ import { InProcessService } from './service/in-process/in-process-service'; | |||
|
|
|||
| export class FlagdProvider implements Provider { | |||
| metadata = { | |||
| name: 'flagd Provider', | |||
| name: 'flagd', | |||
There was a problem hiding this comment.
| get events() { | ||
| return this._events; | ||
| } | ||
| readonly events = new OpenFeatureEventEmitter(); |
There was a problem hiding this comment.
Remove status handling since the SDK takes care of that for us now.
| ); | ||
| this.logger?.debug(`${this.metadata.name}: ready`); | ||
| } catch (err) { | ||
| this.logger?.error(`${this.metadata.name}: error during initialization: ${(err as Error)?.message}`); |
There was a problem hiding this comment.
Do we want to leave this as log level error?
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
commented
Jan 7, 2025
There was a problem hiding this comment.
TODO: review this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1115
Notes
The RPC implementation still needs to be updated.
Follow-up Tasks
How to test