fix: Update usage of StatsigServerOptions #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Henneberg <[email protected]>
Signed-off-by: Jens Henneberg <[email protected]>
Signed-off-by: Jens Henneberg <[email protected]>
beeme1mr
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the way
StatsigServerOptionsare passed to theStatsigProviderThe previous api took an
Action<StatsigServerOptions>. While this was a nicer api, it did unfortunately not work as most of the fields onStatsigServerOptionscan only be set in the constructor.Notes
A few typos are also fixed
Follow-up Tasks
The updates in the README uncovers an example of the inconsistency mentioned here. I'm considering whether to rename the NuGet package (OpenFeature.Contrib.Providers.Statsig) to match the Project name (OpenFeature.Contrib.Providers.Statsig)