Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define behavior of ENABLE register for devices with no read channel #31

Closed
wants to merge 2 commits into from
Closed

Define behavior of ENABLE register for devices with no read channel #31

wants to merge 2 commits into from

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Nov 6, 2024

@jonnew jonnew requested a review from aacuevas November 6, 2024 18:54
aacuevas
aacuevas approved these changes Nov 8, 2024
View reviewed changes
Copy link

@aacuevas aacuevas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using the C notation for binary values (0bxxxx) ? And, are we using that when specifying single bits 0b0/0b1 vs code-block `0` / `1` ?

We should revise the whole text for consistency on binary notation.

@jonnew
Copy link
Member Author

jonnew commented Nov 9, 2024

I checked for occurrences of 0b and 0x using git grep. I think 0x is the way to go. To be unambiguous, I've widened this literals to match the width of whatever register or address, or portion thereof, that they are referring to.

@jonnew
Widen value literals to appropriate width
4b93704 
- Try to use hex notation throughout
- Match the width of whatever register or address,
  or portion thereof, a literal value refers to
@jonnew jonnew requested a review from aacuevas November 9, 2024 18:35
@jonnew jonnew marked this pull request as draft November 19, 2024 16:51
@aacuevas
Copy link

Already fixed in #54

@aacuevas aacuevas closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aacuevas aacuevas Awaiting requested review from aacuevas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define behavior of ENABLE if there is no device data stream
2 participants
@jonnew @aacuevas