Remove data width requirements for high-bandwidth streams #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonnew
commented
Nov 4, 2024
jonnew
commented
- High bandwidth streams, from the perspective of API and device table entries, now operate on bytes
- The hardware is permitted to use trailing padding to meet internal alignment requirements
- Fixes Clarify high-bandwidth stream data alignment requirements #3
- High bandwidth streams, from the perspective of API and device table entries, now operate on bytes - The hardware is permitted to use trailing padding to meet internal alignement requirements
jonnew
commented
Nov 9, 2024
| Frame time (:macro:`ONI_OPT_ACQCLKHZ` host clock counter). | ||
|
|
||
| .. member:: const oni_fifo_dat_t dev_idx | ||
| .. member:: const oni_size_t dev_idx |
There was a problem hiding this comment.
I did this without thinking for aesthetic reasons (completely discounting memory ordering in C) but it happens to address #30. The size and counter are also swapped though which is probably not desired.
|
Already fixed in #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.