Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create xblocks #2

Merged
merged 3 commits into from
Aug 31, 2024
Merged

feat: create xblocks #2

merged 3 commits into from
Aug 31, 2024

Conversation

CefBoud
Copy link
Contributor

@CefBoud CefBoud commented Jul 16, 2024 •
edited
Loading

Testing instructions

  1. Clone the repository and switch to the PR branch create-xblocks.
  2. Add it as a tutor mount tutor mounts add /workspace/xblock-ai-completion
  3. Rebuild the Docker image tutor images build openedx-dev
  4. Start tutor tutor dev start
  5. Install the XBlock inside the LMS and CMS containers 
    tutor dev run cms bash
pip install -e /mnt/xblock-ai-evaluation

tutor dev run lms bash
pip install -e /mnt/xblock-ai-evaluation
  6. Restart the LMS and CMS containers 
    tutor dev restart cms
tutor dev restart lms
  7. In the Open edX platform, navigate to Settings > Advanced Settings and add shortanswer_ai_eval and coding_ai_eval to the Advanced Module List.
  8. Add either XBlock using the Advanced button in the Add New Component section of Studio.
  9. Configure the added Xblock and make sure to add correct API keys. You can format your question and prompts using Markdown.

@CefBoud CefBoud force-pushed the create-xblocks branch 5 times, most recently from 1a98a05 to eab1831 Compare July 16, 2024 17:24
pkulkark
pkulkark reviewed Jul 19, 2024
View reviewed changes
ai_eval/base.py Outdated Show resolved Hide resolved
ai_eval/base.py Show resolved Hide resolved
ai_eval/coding_ai_eval.py Outdated Show resolved Hide resolved
ai_eval/coding_ai_eval.py Show resolved Hide resolved
ai_eval/base.py Show resolved Hide resolved
@CefBoud CefBoud force-pushed the create-xblocks branch 3 times, most recently from 74794a0 to 8970746 Compare July 29, 2024 17:07
tecoholic
tecoholic requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CefBoud Hi, this is such a big block of work. Great job so far. I have suggested a few improvements.

ai_eval/static/js/src/coding_ai_eval.js Outdated Show resolved Hide resolved
ai_eval/static/js/src/coding_ai_eval.js Outdated Show resolved Hide resolved
ai_eval/static/js/src/coding_ai_eval.js Show resolved Hide resolved
ai_eval/static/js/src/coding_ai_eval.js Outdated Show resolved Hide resolved
ai_eval/static/js/src/coding_ai_eval.js Show resolved Hide resolved
ai_eval/utils.py Outdated Show resolved Hide resolved
ai_eval/utils.py Show resolved Hide resolved
ai_eval/utils.py Outdated Show resolved Hide resolved
requirements/base.in Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@CefBoud CefBoud force-pushed the create-xblocks branch 5 times, most recently from 64ae0c3 to c50f823 Compare August 2, 2024 15:17
@CefBoud
feat: create xblocks
01b6280 
feat: add HTML/CSS support

fix: minor changes

fix: remove the extra space around the code editor

* extra space on right was caused by the 100vh for
  width instead of 100vw
* on the left, the default lineNumbersMinChars value
  of 5 was causing a huge margin, along with the
  code folding gutter.
  See: suren-atoyan/monaco-react#303

fix: add the border and the box showdow to match mockup styling

fix: scroll just the tab content instead, not parent container

fix: make the tab switches smaller to match mockups

fix: submission button styling and border

fix: added multiple fixes and tweaks

fix: added multiple fixes and tweaks

fix: styling adjustments for the prog language badge
@CefBoud CefBoud merged commit 29a4073 into main Aug 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecoholic tecoholic tecoholic requested changes

@pkulkark pkulkark pkulkark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CefBoud @tecoholic @pkulkark