Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add slots for video and file upload components and alerts #77

Merged

Conversation

xitij2000
Copy link
Member

This change add plugin slots for the file and video upload components, and the alerts components on those pages.

(cherry picked from commit 9c79a41)

@xitij2000 xitij2000 force-pushed the kshitij/plugin-slots/files-and-alerts.redwood branch 3 times, most recently from c8f5b3a to 440f319 Compare December 20, 2024 08:28
This change add plugin slots for the file and video upload components, and the alerts components on those pages.

(cherry picked from commit 9c79a41)
@xitij2000 xitij2000 force-pushed the kshitij/plugin-slots/files-and-alerts.redwood branch from 440f319 to 2cd1e96 Compare December 20, 2024 08:36
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.72650% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.65%. Comparing base (acbd7fa) to head (2cd1e96).
Report is 13 commits behind head on asu-moe/redwood-css.

Files with missing lines Patch % Lines
src/files-and-videos/generic/EditFileErrors.jsx 69.23% 4 Missing ⚠️
src/plugin-slots/CourseVideosSlot/index.jsx 98.27% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #77      +/-   ##
=======================================================
+ Coverage                92.54%   92.65%   +0.10%     
=======================================================
  Files                      706      710       +4     
  Lines                    12515    12564      +49     
  Branches                  2728     2740      +12     
=======================================================
+ Hits                     11582    11641      +59     
+ Misses                     898      888      -10     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xitij2000 xitij2000 merged commit b7e496b into asu-moe/redwood-css Dec 23, 2024
5 checks passed
@xitij2000 xitij2000 deleted the kshitij/plugin-slots/files-and-alerts.redwood branch December 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant