[Temporary] feat: Taxonomy export menu #4
Conversation
Internal issue: https://2u-internal.atlassian.net/browse/TNL-11085 File upload gallery cards had distorted thumbnails. The goal is to fix this. I centered the thumbnails instead of stretching them. I had to change the card layout a bit to do that, so in order to make everything look fine, I worked a bit on margins and paddings and font-size in order to bring this close to the figma mockups. It's not perfect because when you resize the browser window, the grid does some resizing that doesn't look as good as in figma, but I think it should be good enough for now.
…v1.175.0 (openedx#631) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Changed "Files & Uploads" page title to just "Files"
ChrisChV
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chris/FAL-3522-taxonomy-list-page #4 +/- ##
====================================================================
Coverage ? 86.86%
====================================================================
Files ? 384
Lines ? 5779
Branches ? 1270
====================================================================
Hits ? 5020
Misses ? 735
Partials ? 24 ☔ View full report in Codecov by Sentry. |
src/taxonomy/api/hooks/api.js
Outdated
| fileExtension = 'csv'; | ||
| data = response.data; | ||
| } | ||
| downloadDataAsFile(data, contentType, `${name}.${fileExtension}`); |
There was a problem hiding this comment.
Calling the endpoint with the parameter download=1 you could get the filename and extension from the backend using the Content-Disposition and simplify a bit here.
Another alternative is to leave the front end as it is and remove the download option to simplify the backend.
What do you think?
There was a problem hiding this comment.
@rpenido We need to call the endpoint using Axios because the call needs to be authenticated. I have tried using download=1, but doesn't works, here is the explanation. I've added that as a comment.
Another alternative is to leave the front end as it is and remove the download option to simplify the backend.
I think yes, we need to remove that because it will no longer be necessary, but it would be done in a follow-up task, I'm already running out of time here CC @bradenmacdonald
There was a problem hiding this comment.
Doesn't the user have cookie authentication for the CMS domain? You don't want to call it as an API using Axios/fetch, you just want to send the user's browser to that URL. window.location.href = '/path/to/download/api?download=1 - like that. Or even better, use <a href="/path/to/api?download=1">Download</a>. And @rpenido is right, you shouldn't need to specify the filename.
There was a problem hiding this comment.
I also thought that the authentication would be a problem, but @bradenmacdonald is right. Making a request directly to the backend using the authenticated browser section worked (in my setup).
There was a problem hiding this comment.
@rpenido How did you make the request? I have tried window.location.href way but doesn't work. CC @bradenmacdonald
vokoscreenNG-2023-10-20_12-22-40.mp4
There was a problem hiding this comment.
@ChrisChV Weird. It works for me - I just went to http://studio.local.overhang.io:8001/api/content_tagging/v1/taxonomies/1/export/?output_format=json&download=1 (the tutor devstack equivalent URL) in my browser and it downloaded a file.
If you go to http://localhost:18010 are you logged in to Studio?
There was a problem hiding this comment.
@ChrisChV I think you are using an old version of openedx-learning, and you're missing this commit: openedx/openedx-learning@d66d629
There was a problem hiding this comment.
If you go to http://localhost:18010/ are you logged in to Studio?
Yes, that is it. Now it works, thanks! That simplifies things
There was a problem hiding this comment.
Your code worked here @ChrisChV.
Why does the API not allow exporting system-defined taxonomies? I discussed this with Axim and we decided that some power users may want to export system-level taxonomies, and there's no reason to prevent it. Not in scope to fix now though. |
…penedx#646) Part of openedx/axim-engineering#23 This updates the `@edx/brand` alias to point to the `brand-openedx` package at the `openedx` scope. This does not impact imports because this package is used via an alias.
ChrisChV
force-pushed
the
chris/FAL-3528-taxonomy-export-menu
branch
from
667bf1e to
09aa8b6
Compare
Changes added:
Screenshots
Testing instructions
Export.Exporton the Export modal with CSV format.Exporton the Export modal with JSON format.Other info