Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to have custom logger #522

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Add ability to have custom logger #522

merged 2 commits into from
Dec 31, 2024

Conversation

mwood23
Copy link
Contributor

@mwood23 mwood23 commented Dec 18, 2024

The types allow for a custom logger to be passed in but it's never used.

gustavohenke
gustavohenke requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind fixing the formatting errors?

@mwood23
Copy link
Contributor Author

mwood23 commented Dec 29, 2024

@gustavohenke No problem! Just wanted to make sure you'd like to take the change first. PR updated. Thanks for the awesome lib 🚀

@coveralls
Copy link

Coverage Status

coverage: 98.18%. remained the same
when pulling e206348 on mwood23:patch-1
into 6cafc60 on open-cli-tools:main.

@gustavohenke gustavohenke merged commit 36eccae into open-cli-tools:main Dec 31, 2024
21 checks passed
@gustavohenke
Copy link
Member

Published as v9.1.2.

Happy new year!

@renovate renovate bot mentioned this pull request Jan 3, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwood23 @coveralls @gustavohenke