Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the Grafana JSON file #134

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

LifengWang
Copy link
Collaborator

@LifengWang LifengWang commented Sep 19, 2024

Description

Enhance the Grafana JSON file for ChatQnA MegaService, TEI, and TGI.

  • Remove the hardcoded data source uid.
  • Replace the "container" with "job" as the filter for the metrics.
  • Update the Readme.

Issues

#128

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

N/A

Tests

Local tests.

@ChengyuZhu6
Copy link

The Grafana JSON files ( including embedding, dataprep, rerank, retrieval ) have similar issues. Could we consider modifying them all together?

lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
@LifengWang LifengWang merged commit 8653efb into opea-project:main Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants