Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nettests): failing to start a nettest is a warning #1373

Merged
merged 2 commits into from
Oct 18, 2023
+4 −2
Merged

fix(nettests): failing to start a nettest is a warning #1373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8e918f
fix(nettests): failing to start a nettest is a warning
bassosimone Oct 18, 2023
d41d1ee
[ci skip] Update cmd/ooniprobe/internal/nettests/run.go
bassosimone Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/ooniprobe/internal/nettests/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func RunGroup(config RunGroupConfig) error {
return err
}
if err := sess.MaybeLookupBackends(); err != nil {
log.WithError(err).Warn("Failed to discover OONI backends")
log.WithError(err).Errorf("Failed to discover OONI backends")
return err
}

Expand Down Expand Up @@ -116,7 +116,9 @@ func RunGroup(config RunGroupConfig) error {
ctl.RunType = config.RunType
ctl.SetNettestIndex(i, len(group.Nettests))
if err = nt.Run(ctl); err != nil {
log.WithError(err).Errorf("Failed to run %s", group.Label)
// We used to emit an error here, now we emit a warning--the proper choice
// given that we continue running. See https://github.com/ooni/probe/issues/2576.
log.WithError(err).Warnf("Failed to run %s", group.Label)
}
}

Expand Down