Skip to content

Commit

Permalink
x
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone committed Jun 27, 2024
1 parent 620d4f9 commit 7b82000
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/oonirun/inputprocessor.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ func (ip *InputProcessor) run(ctx context.Context) (int, error) {
if err != nil {
// TODO(bassosimone): when re-reading this code, I find it confusing that
// we return on error because I am always like "wait, this is not the right
// thing to do here". Then, I remember that the experimentSubmitterWrapper
// thing to do here". Then, I remember that the experimentSubmitterWrapper{}
// ignores this error and so it's like it does not exist. Maybe we should
// rewrite the code to do the right thing here.
// rewrite the code to do the right thing here 😬😬😬.
return 0, err
}
// Note: must be after submission because submission modifies
Expand Down

0 comments on commit 7b82000

Please sign in to comment.