Skip to content

Commit

Permalink
doc: explain issues caused by adding HTTP response
Browse files Browse the repository at this point in the history
We're introducing failure modes that do not exist hence it seems
this is not the correct way of moving forward.
  • Loading branch information
bassosimone committed Nov 23, 2023
1 parent d6cbfd9 commit 41fbd3f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion internal/experiment/webconnectivityqa/tcpblocking.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ import (
// where the connection is timed out.
func tcpBlockingConnectTimeout() *TestCase {
return &TestCase{
Name: "tcpBlockingConnectTimeout",
Name: "tcpBlockingConnectTimeout",
// TODO(bassosimone): this test case transitions from 2 (TCP/IP blocking) to
// 10 (both TCP/IP blocking and HTTP blocking). The reason why this happens is
// that we're now adding an HTTP request to the mix. This is unfortunate. We
// should not flag HTTP failures here inside of the bitmask.
Flags: 0,
Input: "https://www.example.com/",
Configure: func(env *netemx.QAEnv) {
Expand Down

0 comments on commit 41fbd3f

Please sign in to comment.